feat: support host monitor #1890
Open
+1,714
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
force-pushed
the
host_monitor
branch
6 times, most recently
from
6150e52 to
bfdd9c2
Compare
messixukejia
requested changes
Nov 25, 2024
henryzhx8
requested changes
Nov 26, 2024
Abingcbc
force-pushed
the
host_monitor
branch
from
4110e3d to
3e12438
Compare
messixukejia
requested changes
Nov 30, 2024
|
|
||
| int readCount = 0; | ||
| WalkAllProcess(PROCESS_DIR, [&](const std::string& dirName) { | ||
| if (++readCount > mProcessSilentCount) { |
There was a problem hiding this comment.
个数控制是不是也在控制缓存里的？不应该只是控制去直接操作系统交互的吗
There was a problem hiding this comment.
缓存是为了计算增量的CPU使用率，前一次和后一次的top n进程可能不一样，所以需要保存所有的
messixukejia
requested changes
Dec 4, 2024
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "InputHostMeta.h" |
| ThreadPool mThreadPool; | ||
|
|
||
| mutable std::shared_mutex mRegisteredCollectorMapMutex; | ||
| std::unordered_map<std::string, bool> mRegisteredCollectorMap; |
There was a problem hiding this comment.
std::unordered_map<std::string, bool> mRegisteredCollectorMap;
std::unordered_map<std::string, std::shared_ptr<BaseCollector>> mCollectorInstanceMap;
这两个变量有点不合理。
包括
1、HostMonitorInputRunner::GetCollector的使用上。应该是自闭环合法性
2、锁的关系等
3、RegisterCollector 操作的变量是 mCollectorInstanceMap，但是另一个没操作的变量却叫reg
可能的优化
1、保持现有逻辑。一组功能不用过多发散变量，以上改成一个map。value用结构体表示。整体实现结构优化下。
2、UpdateCollector时再注册ProcessEntityCollector实例，这样能省一个变量。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO：