feature:add global or ip or header rate limiting plugin #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
683 需要基于redis实现 |
johnlanni
reviewed
Dec 12, 2023
| var err error | ||
| for i := 0; i < 10; i++ { // cas冲突时会重试10次 | ||
| binary.LittleEndian.PutUint64(buf, uint64(value+1)) | ||
| err = proxywasm.SetSharedData(cacheKey, buf, cas) |
There was a problem hiding this comment.
这个 shareddata 没有过期机制，这样写会导致内存泄漏
There was a problem hiding this comment.
这块的目的是，如果出现并发冲突，就进行重试，一共最多重拾10次
There was a problem hiding this comment.
嗯，我的意思是这里的key太发散了，跟时间戳相关
There was a problem hiding this comment.
是的，key的话，每秒都会有新key出现，我又做了一个时间窗口的，基于totp生成key，比这个稍微好一些。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
global or ip or header rate limiting plugin
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
envoy filter config this wasm plugin,then limit refresh page.
Ⅴ. Special notes for reviews