[server] Fix config 'netty.server.max-queued-requests' don't work which cause server receive unlimited requests error #276
+91
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch cause server receive unlimited requests error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #268
This pr is aims to fix the error that the server will receive unlimited requests even if we config the
netty.server.max-queued-requeststo a specify number.This issue arose because we introduced a
PriorityBlockingQueuein theRequestChannelto replace theArrayBlockingQueue. ThePriorityBlockingQueue, unlike theArrayBlockingQueue, is an unbounded queue.Therefore, in this PR, we introduced two
ArrayBlockingQueuesin theRequestChannel: one specifically for handling replicaSync requests. This not only achieves the goal of prioritizing replicaSync requests but also ensures that the number of requests received by the cluster is limited.Tests
API and Format
Documentation