[kv] Support first row merge engine #240
Merged
+378
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchong
requested changes
Dec 21, 2024
fluss-client/src/test/java/com/alibaba/fluss/client/table/FlussTableITCase.java
Outdated
Show resolved
Hide resolved
...nnector-flink/src/main/java/com/alibaba/fluss/connector/flink/catalog/FlinkTableFactory.java
Outdated
Show resolved
Hide resolved
...nnector-flink/src/test/java/com/alibaba/fluss/connector/flink/sink/FlinkTableSinkITCase.java
Outdated
Show resolved
Hide resolved
|
@wuchong Comments addressed... |
wuchong
reviewed
Dec 23, 2024
| if (mergeEngine != null && mergeEngine == ConfigOptions.MergeEngine.FIRST_ROW) { | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "Table %s is with merge engine '%s'. Table with '%s' merge engine doesn't support DELETE and UPDATE statements.", |
There was a problem hiding this comment.
Table xxx uses the 'first_row' merge engine, which does not support DELETE or UPDATE statements.
| @@ -712,6 +745,35 @@ void testUnsupportedDeleteAndUpdateStmtOnPartialPK() { | |||
| "Currently, Fluss table only supports UPDATE statement with conditions on primary key."); | |||
| } | |||
|
|
|||
| @Test | |||
| void testUnsupportedDeleteAndUpdateStmtOnFirstRowMergeEngine() { | |||
Comment on lines
149
to
151
| key(ConfigOptions.TABLE_MERGE_ENGINE.key()) | ||
| .enumType(ConfigOptions.MergeEngine.class) | ||
| .noDefaultValue()); |
wwj6591812
reviewed
Dec 24, 2024
...uss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/sink/FlinkTableSink.java
Outdated
Show resolved
Hide resolved
...connector-flink/src/main/java/com/alibaba/fluss/connector/flink/source/FlinkTableSource.java
Outdated
Show resolved
Hide resolved
luoyuxia
force-pushed
the
support-first-row-merge-engin
branch
from
e64b962 to
9de11b8
Compare
|
@wuchong Comments addressed again... |
wuchong
force-pushed
the
support-first-row-merge-engin
branch
from
9de11b8 to
1353756
Compare
wuchong
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
LGTM. @luoyuxia I appended a commit to improve the config operations:
- Move
MergeEngineout ofConfigOptions, as it is very widely used in the code base, just likeKvFormat. - use
toFlinkOptionfor quick/easy conversion from Fluss ConfigOption to Flink ConfigOption, avoid duplicate definition inFlinkTableFactory.
2 tasks
|
The CI is passed. I will merge it... @luoyuxia please check the commit I appended. |
1 similar comment
|
The CI is passed. I will merge it... @luoyuxia please check the commit I appended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #133
Introduce first row merge engine for primary key table
Tests
FlussTableITCase#testFirstRowMergeEngine
FlinkTableSinkITCase#testFirstRowMergeEngine
API and Format
N/A
Documentation
I'd like to complete the document in another pr #241 since after introduce merge engine, we may need to refactor the document struture about primary key table.