[server] FetchLogRequest support params: minFetchBytes and maxWaitMs to avoid frequently FetchLogRequest send to server #233
+1,182
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swuferhong
force-pushed
the
fetch-log-min-size
branch
from
dac408f to
7e9a002
Compare
2 tasks
wuchong
reviewed
Dec 29, 2024
fluss-server/src/main/java/com/alibaba/fluss/server/log/LogOffsetMetadata.java
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/log/LogOffsetSnapshot.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/replica/delay/DelayedFetchLog.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/com/alibaba/fluss/metrics/MetricNames.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/replica/ReplicaManager.java
Outdated
Show resolved
Hide resolved
fluss-server/src/main/java/com/alibaba/fluss/server/replica/ReplicaManager.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/com/alibaba/fluss/server/tablet/TabletServiceITCase.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/com/alibaba/fluss/server/replica/delay/DelayedFetchLogTest.java
Outdated
Show resolved
Hide resolved
fluss-server/src/test/java/com/alibaba/fluss/server/replica/delay/DelayedFetchLogTest.java
Outdated
Show resolved
Hide resolved
fluss-common/src/main/java/com/alibaba/fluss/config/ConfigOptions.java
Outdated
Show resolved
Hide resolved
swuferhong
force-pushed
the
fetch-log-min-size
branch
3 times, most recently
from
a9bb612 to
ec71d91
Compare
|
@wuchong comments addressed. |
swuferhong
force-pushed
the
fetch-log-min-size
branch
from
ec71d91 to
08b7018
Compare
…to avoid frequently FetchLogRequest send to server
swuferhong
force-pushed
the
fetch-log-min-size
branch
from
08b7018 to
2c4ef5d
Compare
|
@wuchong conflict resolved, pr ready. |
wuchong
approved these changes
Jan 5, 2025
|
CI is passed, Merging... Please check the commit afterward @swuferhong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #199
This pr is aims to deal with the problem mention in #199 (Client/Follower fetch a empty table, the response will be returned quickly, and immediately, it'll send fetch request again and again)
Tests
API and Format
Documentation