rightMenu #88
Open
rightMenu #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wb-wcq372632 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
src/canvas/baseCanvas.less
Outdated
| @@ -41,7 +41,79 @@ | |||
| display: block; | |||
| } | |||
| } | |||
|
|
|||
| .endpoint-tips-menu{ | |||
There was a problem hiding this comment.
这个menu应该是能支持所有的节点，名字有问题
src/service/sevice.js
Outdated
| const _ = require('lodash'); | ||
|
|
||
|
|
||
| function createMenuList(param, callBack, e) { |
There was a problem hiding this comment.
抽象库不能这样写。。。event是业务或者外部耦合的，不应该传进来处理
src/service/sevice.js
Outdated
| top: evt.clientY | ||
| }; | ||
| if (param.type === 'tips') { | ||
| $(document.body).find('.endpoint-tips-menu').remove(); |
src/service/sevice.js
Outdated
| left: evt.clientX, | ||
| top: evt.clientY | ||
| }; | ||
| if (param.type === 'tips') { |
index.js
Outdated
| module.exports = { | ||
| Canvas, | ||
| Edge, | ||
| Endpoint, | ||
| Group, | ||
| Node | ||
| Node, | ||
| ServiceCanvas |
added 2 commits
March 7, 2019 17:11
| const $ = require('jquery'); | ||
| const _ = require('lodash'); | ||
|
|
||
| class MenuService { |
There was a problem hiding this comment.
我不太建议写成clasa，假如用户想使用的话，应该比较简单地let menuSrevices = require('xxx');menuSrevices.shou(xxx);这样比较清爽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rightMenu