Fix test-throttle CI #692
Fix test-throttle CI #692
Conversation
| @@ -34,13 +34,13 @@ jobs: | |||
| -D PHOTON_ENABLE_URING=ON \ | |||
| -D PHOTON_ENABLE_LIBCURL=ON \ | |||
| -D PHOTON_ENABLE_EXTFS=ON | |||
| cmake --build build -j $(nproc) -- VERBOSE=1 | |||
| cmake --build build -j $(nproc) | |||
There was a problem hiding this comment.
打算精简CI的日志。
现在日志过于冗长了。而且包含了一些似乎不应该出现的ERROR，跟DEBUG和INFO混在一起，不够明显。
看看是不是需要把所有CI日志都设置成WARNING？
I'm planning to simplify the CI logs since they are currently too verbose. Additionally, there are some ERROR messages that seem inappropriate, mixed in with DEBUG and INFO, making them less distinct. What do you think?
There was a problem hiding this comment.
要不这样：加个命令行参数来手动控制log level？默认还是DEBUG，这样CI出问题之后尽可能保留信息；手动debug的时候也不致于太烦冗。
There was a problem hiding this comment.
ctest貌似没法传递gflags参数。@Coldwings 知道什么其他办法吗？
或者再增加一个Env
There was a problem hiding this comment.
@lihuiba 现在情况是CI日志太多可能隐藏问题，比如这个
2025-01-06T08:42:42.4161762Z 51: [ RUN ] ExtfsTest.Unlink
2025-01-06T08:42:42.4162673Z 51: 2025/01/06 08:42:42.414495|ERROR|th=0000000001BBC090|test.cpp:88|lstat:failed lstat [path=/dir1/file3_symlink] errno=2(No such file or directory)
2025-01-06T08:42:42.4164149Z 51: 2025/01/06 08:42:42.414506|ERROR|th=0000000001BBC090|test.cpp:160|unlink:failed unlink [path=/dir1/file6_symlink] errno=2(No such file or directory)
2025-01-06T08:42:42.4165508Z 51: 2025/01/06 08:42:42.414509|ERROR|th=0000000001BBC090|test.cpp:160|unlink:failed unlink [path=/dir1] errno=21(Is a directory)
我觉得CI的作用是告诉我们最终是成功了还是失败了，具体怎么失败的可以线下复现。同时通过ERROR日志，打印一些虽然过程异常但是结果没报失败的case，引起关注。
beef9999
force-pushed
the
fix-test-throttle-CI
branch
2 times, most recently
from
965a975 to
0a4ef25
Compare
| @@ -34,13 +34,13 @@ jobs: | |||
| -D PHOTON_ENABLE_URING=ON \ | |||
| -D PHOTON_ENABLE_LIBCURL=ON \ | |||
| -D PHOTON_ENABLE_EXTFS=ON | |||
| cmake --build build -j $(nproc) -- VERBOSE=1 | |||
| cmake --build build -j $(nproc) | |||
There was a problem hiding this comment.
要不这样：加个命令行参数来手动控制log level？默认还是DEBUG，这样CI出问题之后尽可能保留信息；手动debug的时候也不致于太烦冗。
beef9999
force-pushed
the
fix-test-throttle-CI
branch
3 times, most recently
from
cd578f1 to
6cd3742
Compare
beef9999
force-pushed
the
fix-test-throttle-CI
branch
from
6cd3742 to
11f5df9
Compare
No description provided.