-
Notifications
You must be signed in to change notification settings - Fork 16
Feature/sdks updates 251206 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| async def get_context(self, context_id: str) -> CodeContext: | ||
| try: | ||
| from opensandbox.api.execd.api.code_interpreting import get_context | ||
| from opensandbox.api.execd.models.code_context import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add generated execd client for new context APIs
The new context helpers call opensandbox.api.execd.api.code_interpreting.get_context when fetching a context, but the repository still contains no generated execd client package (find . -path '*api/execd*' returns nothing), and no regenerated client code was added alongside the spec change that introduced GET /code/contexts/{context_id}. At runtime the first call to get_context/list_contexts will raise ModuleNotFoundError because the referenced module is absent, so the new context management APIs cannot be used until the execd client is regenerated and checked in (same issue for the sync adapter).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下一个PR统一提交下Openapi的生成代码
|
@codex Do you only find one problem at a time? |
|
To use Codex here, create an environment for this repo. |
...interpreter/src/main/kotlin/com/alibaba/opensandbox/codeinterpreter/domain/services/Codes.kt
Show resolved
Hide resolved
Pangjiping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
🚀 Features
🛠 Refactoring & Cleanup
code-interpreter,移除 Sandbox 管理相关接口,实现彻底解耦。code-interpreterby removing sandbox management interfaces.create/connect/resume)。Testing
Breaking Changes
Checklist