Skip to content

Conversation

@ninan-nn
Copy link
Collaborator

@ninan-nn ninan-nn commented Dec 29, 2025

Summary

🚀 Features

  • Code Context Management: 支持额外的代码上下文管理操作 (E2E 测试待补全)。
    • Added support for additional code context management (E2E tests pending).
  • Healthcheck Toggle: 支持通过配置跳过 Healthcheck。
    • Support skipping healthcheck via configuration.

🛠 Refactoring & Cleanup

  • Decoupling (Breaking Change): 优化 code-interpreter,移除 Sandbox 管理相关接口,实现彻底解耦。
    • Decoupled code-interpreter by removing sandbox management interfaces.
  • Sandbox Methods: 重构 Sandbox 实例获取方法 (create / connect / resume)。
    • Refactored sandbox instance lifecycle methods.
  • fix all pyright check issue: 修复并通过pyright的类型检测

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (优化 code-interpreter 不再透出 sandbox 管理接口)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@jwx0925
Copy link
Collaborator

jwx0925 commented Dec 30, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +170 to +173
async def get_context(self, context_id: str) -> CodeContext:
try:
from opensandbox.api.execd.api.code_interpreting import get_context
from opensandbox.api.execd.models.code_context import (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add generated execd client for new context APIs

The new context helpers call opensandbox.api.execd.api.code_interpreting.get_context when fetching a context, but the repository still contains no generated execd client package (find . -path '*api/execd*' returns nothing), and no regenerated client code was added alongside the spec change that introduced GET /code/contexts/{context_id}. At runtime the first call to get_context/list_contexts will raise ModuleNotFoundError because the referenced module is absent, so the new context management APIs cannot be used until the execd client is regenerated and checked in (same issue for the sync adapter).

Useful? React with 👍 / 👎.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下一个PR统一提交下Openapi的生成代码

@jwx0925
Copy link
Collaborator

jwx0925 commented Dec 30, 2025

@codex Do you only find one problem at a time?

@chatgpt-codex-connector
Copy link

To use Codex here, create an environment for this repo.

@Pangjiping Pangjiping self-requested a review December 31, 2025 04:03
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants