-
Notifications
You must be signed in to change notification settings - Fork 16
feat(components/execd): add new api for context management #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a1a8f51 to
c630a08
Compare
c630a08 to
124d4ef
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
OpenSandbox/components/execd/pkg/runtime/context.go
Lines 145 to 149 in 650ef8e
| c.defaultLanguageJupyterSessions[language] = session.ID | |
| c.jupyterClientMap[session.ID] = &jupyterKernel{ | |
| kernelID: session.Kernel.ID, | |
| client: client, | |
| } |
Default contexts created in createDefaultLanguageContext store a jupyterKernel without setting its language field (context.go lines 145‑149). Because list APIs use kernel.language, a prewarmed session will be reported twice—once with an empty language from jupyterClientMap and once with the actual language from defaultLanguageJupyterSessions—after the first request without an explicit context, causing duplicate and misleading entries in /code/contexts.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Testing
Breaking Changes
Checklist