Skip to content

Conversation

@Pangjiping
Copy link
Collaborator

Summary

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Pangjiping Pangjiping added the enhancement New feature or request label Dec 25, 2025
@Pangjiping Pangjiping force-pushed the feat/execd/contextmanagement branch 2 times, most recently from a1a8f51 to c630a08 Compare December 25, 2025 12:52
@Pangjiping Pangjiping force-pushed the feat/execd/contextmanagement branch from c630a08 to 124d4ef Compare December 25, 2025 12:58
@jwx0925
Copy link
Collaborator

jwx0925 commented Dec 30, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

c.defaultLanguageJupyterSessions[language] = session.ID
c.jupyterClientMap[session.ID] = &jupyterKernel{
kernelID: session.Kernel.ID,
client: client,
}

P2 Badge Populate language when creating default contexts

Default contexts created in createDefaultLanguageContext store a jupyterKernel without setting its language field (context.go lines 145‑149). Because list APIs use kernel.language, a prewarmed session will be reported twice—once with an empty language from jupyterClientMap and once with the actual language from defaultLanguageJupyterSessions—after the first request without an explicit context, causing duplicate and misleading entries in /code/contexts.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants