fix bug of undefined flags of easyrec tools run with DeepRec #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradiseHIT
reviewed
Jan 2, 2025
easy_rec/python/utils/io_util.py
Outdated
| unknown = False | ||
| for arg in args[1:]: | ||
| if arg.startswith('--'): | ||
| flag_name = arg.split('=')[0][2:] |
There was a problem hiding this comment.
我看有的参数后面跟的是空格，--config_path oss://xxxxx/a.json 这种，需要考虑空格分隔符这种
There was a problem hiding this comment.
如果分隔符是空格，args[1:] 遍历可能会复杂，有--key value, --key, --key=value三种形式要考虑
There was a problem hiding this comment.
目前这三种情况“--key value, --key, --key=value“ 都已经考虑了；另外，tf.app.flags不支持短参数（即单个字母的参数，如 -h）
paradiseHIT
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.