Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(parameter_sync): offer 2 GPU memory optimization levels in broadcasting parameters #195

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feature(parameter_sync): offer 2 GPU memory optimization levels in broadcasting parameters #195

wants to merge 18 commits into from

Conversation

haolin-nju
Copy link
Collaborator

@haolin-nju haolin-nju commented Dec 27, 2024 •
edited
Loading

This PR includes:

  1. offering 2 levels of GPU memory optimization level in broadcasting parameters (one-stage and two-stage)
  2. supresses GPU memory utilization in broadcast (one-stage)

charles9304
charles9304 previously approved these changes Dec 27, 2024
View reviewed changes
adoda
adoda previously approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@adoda adoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haolin-nju haolin-nju changed the title fix(parameter_sync): Suppress GPU memory utilization in broadcast feature(parameter_sync): offer 2 levels of GPU memory optimization level in broadcasting parameters Jan 3, 2025
@haolin-nju haolin-nju changed the title feature(parameter_sync): offer 2 levels of GPU memory optimization level in broadcasting parameters feature(parameter_sync): offer 2 GPU memory optimization levels in broadcasting parameters Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charles9304 charles9304 charles9304 left review comments

@adoda adoda adoda left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haolin-nju @adoda @charles9304