New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added override to name property on error.ts #1552

Open

thegnuu wants to merge 1 commit into algolia:main from thegnuu:fix/error-override

thegnuu commented Sep 13, 2024 •

edited

Loading

When using this library with the newest angular version (v18.2.2), the following error will be thrown.

You can "fix" the issue by using noImplicitOverride: false in the tsconfig, but I guess it would make sense to fix it here...

✖ Compiling with Angular sources in Ivy partial compilation mode.
node_modules/@algolia/client-common/src/transporter/errors.ts:4:3 - error TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Error'.

4   name: string = 'AlgoliaError';

This PR adds the missing override property and should fix this issue.


fix(error-transporter): add override to name property

1019a92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment