Merge pull request #45 from alfg/private-flag

Add private flag property for stats and profile pages.
alfg · Jun 27, 2018 · d07feea · d07feea
2 parents 209b898 + f62b3bb
commit d07feea
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/api/package.json b/api/package.json
@@ -1,6 +1,6 @@
 {
   "name": "overwatch-api",
-  "version": "0.4.1",
+  "version": "0.5.0",
   "description": "An Unoffical Overwatch API.",
   "main": "lib/index.js",
   "engines": {

diff --git a/api/src/parser/profile.js b/api/src/parser/profile.js
@@ -20,6 +20,7 @@ export default function(platform, region, tag, cb) {
     const user = $('.header-masthead').text();
     const level = $('.player-level div').first().text();
     const portrait = $('.player-portrait').attr('src');
+    const permission = $('.masthead-permission-level-text').text();
 
     // Get prestige level by matching .player-level background url hex.
     const prestigeEl = $('.player-level').first().attr('style');
@@ -95,6 +96,7 @@ export default function(platform, region, tag, cb) {
       username: user,
       level: parseInt(level) + prestigeLevel,
       portrait: portrait,
+      private: permission === 'Private Profile',
       games: {
         quickplay: {
           won: parseInt(won.quickplay),

diff --git a/api/src/parser/stats.js b/api/src/parser/stats.js
@@ -20,6 +20,7 @@ export default function(platform, region, tag, cb) {
     const user = $('.header-masthead').text();
     const level = $('.player-level div').first().text();
     const portrait = $('.player-portrait').attr('src');
+    const permission = $('.masthead-permission-level-text').text();
 
     // Get prestige level by matching .player-level background url hex.
     const prestigeEl = $('.player-level').first().attr('style');
@@ -122,6 +123,7 @@ export default function(platform, region, tag, cb) {
       username: user,
       level: parseInt(level) + prestigeLevel,
       portrait: portrait,
+      private: permission === 'Private Profile',
       stats: stats
     }
 

diff --git a/api/test/parser/profile.js b/api/test/parser/profile.js
@@ -3,7 +3,7 @@ import { getProfile } from '../../src/parser';
 
 const platform = 'pc'
 const region = 'us'
-const tag = 'Calvin-1337'
+const tag = 'xQc-11273'
 
 var result;
 
@@ -34,8 +34,8 @@ test('get information of games played by user', t => {
 });
 
 test('get information of user playtime', t => {
-  t.deepEqual(typeof(result.playtime.quickplay), 'string');
-  t.deepEqual(typeof(result.playtime.competitive), 'string');
+  t.not(typeof(result.playtime.quickplay), 'undefined');
+  t.not(typeof(result.playtime.competitive), 'undefined');
 });
 
 test('get information of user competitive stats', t => {

diff --git a/api/test/parser/stats.js b/api/test/parser/stats.js
@@ -3,7 +3,7 @@ import { getStats } from '../../src/parser';
 
 const platform = 'pc'
 const region = 'us'
-const tag = 'Calvin-1337'
+const tag = 'xQc-11273'
 
 var result;
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "overwatch-api-server",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "An Unoffical Overwatch HTTP API",
   "main": "server/index.js",
   "engines": {