removed processResult from Mock

alfeilex · Jan 14, 2025 · bca3a12 · bca3a12
1 parent 9df8953
commit bca3a12
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 25 deletions.
diff --git a/cli/src/test/java/com/devonfw/tools/ide/context/ProcessContextGitMock.java b/cli/src/test/java/com/devonfw/tools/ide/context/ProcessContextGitMock.java
@@ -26,35 +26,21 @@ public class ProcessContextGitMock implements ProcessContext {
 
   private final Path directory;
 
-  private ProcessResult processResult;
+  private List<OutputMessage> outputMessages;
 
   /**
    * @param directory the {@link Path} to the git repository.
    */
   public ProcessContextGitMock(Path directory) {
 
     this.arguments = new ArrayList<>();
-    this.processResult = new ProcessResultImpl("git", "", 0, new ArrayList<>());
     this.directory = directory;
     this.now = LocalDateTime.now();
+    this.outputMessages = new ArrayList<OutputMessage>();
   }
 
-  /**
-   * @return the mocked {@link ProcessResult}
-   */
-  public ProcessResult getProcessResult() {
-
-    return this.processResult;
-  }
-
-  /**
-   * @param exitCode th exit code.
-   * @param output the list of {@link OutputMessage}}
-   * @return the mocked {@link ProcessResult}
-   */
-  public void setProcessResult(int exitCode, List<OutputMessage> output) {
-
-    this.processResult = new ProcessResultImpl("git", "", exitCode, output);
+  public void addOutputMessage(OutputMessage message) {
+    this.outputMessages.add(message);
   }
 
   @Override
@@ -121,7 +107,7 @@ public ProcessResult run(ProcessMode processMode) {
     if (this.arguments.contains("ls-files")) {
       if (Files.exists(this.directory.resolve("new-folder"))) {
         OutputMessage outputMessage = new OutputMessage(false, "new-folder");
-        processResult.getOutputMessages().add(outputMessage);
+        this.outputMessages.add(outputMessage);
       }
     }
     if (this.arguments.contains("clone")) {
@@ -161,8 +147,7 @@ public ProcessResult run(ProcessMode processMode) {
       }
     }
     this.arguments.clear();
-    setProcessResult(exitCode, this.processResult.getOutputMessages());
-    return this.processResult;
+    return new ProcessResultImpl("git", "", exitCode, this.outputMessages);
   }
 
 }
diff --git a/cli/src/test/java/com/devonfw/tools/ide/git/GitContextTest.java b/cli/src/test/java/com/devonfw/tools/ide/git/GitContextTest.java
@@ -73,7 +73,7 @@ public void testRunGitClone(@TempDir Path tempDir) {
     String gitRepoUrl = "https://github.com/test";
     IdeTestContext context = newGitContext(tempDir);
     OutputMessage outputMessage = new OutputMessage(false, "test-remote");
-    this.processContext.getProcessResult().getOutputMessages().add(outputMessage);
+    this.processContext.addOutputMessage(outputMessage);
     // act
     context.getGitContext().pullOrClone(GitUrl.of(gitRepoUrl), tempDir);
     // assert
@@ -92,7 +92,7 @@ public void testRunGitPullWithoutForce(@TempDir Path tempDir) {
     String gitRepoUrl = "https://github.com/test";
     IdeTestContext context = newGitContext(tempDir);
     OutputMessage outputMessage = new OutputMessage(false, "test-remote");
-    this.processContext.getProcessResult().getOutputMessages().add(outputMessage);
+    this.processContext.addOutputMessage(outputMessage);
     FileAccess fileAccess = new FileAccessImpl(context);
     Path gitFolderPath = tempDir.resolve(".git");
     fileAccess.mkdirs(gitFolderPath);
@@ -133,7 +133,7 @@ public void testRunGitPullWithForceStartsReset(@TempDir Path tempDir) {
     }
     IdeTestContext context = newGitContext(tempDir);
     OutputMessage outputMessage = new OutputMessage(false, "test-remote");
-    this.processContext.getProcessResult().getOutputMessages().add(outputMessage);
+    this.processContext.addOutputMessage(outputMessage);
     // act
     context.getGitContext().pullOrCloneAndResetIfNeeded(new GitUrl(gitRepoUrl, "master"), tempDir, "origin");
     // assert
@@ -152,7 +152,7 @@ public void testRunGitPullWithForceStartsCleanup(@TempDir Path tempDir) {
     String gitRepoUrl = "https://github.com/test";
     IdeTestContext context = newGitContext(tempDir);
     OutputMessage outputMessage = new OutputMessage(false, "test-remote");
-    this.processContext.getProcessResult().getOutputMessages().add(outputMessage);
+    this.processContext.addOutputMessage(outputMessage);
     GitContext gitContext = context.getGitContext();
     FileAccess fileAccess = context.getFileAccess();
     Path gitFolderPath = tempDir.resolve(".git");