Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new local maxim_db lookup and accessor for city, for the new API, whi… #1483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pgruener
Copy link

There's also an open issue for this topic #1432

My changes are documented (in README_API_GUIDE.md) and describe how they allow to deal with the updated maximdb download API.

I didn't have enough time, for making it better but in my opinion it's better than a doc, which describes an experimental followup script, which simply doesn't work. (As it is currently - since a year).

I inherited when possible, and duplicated some code (where inheritance wasnt possible).

So the available code will work as before (but the creation of the migration, which is just outdated; and people who already used the old state, already migrated their databases, so it seemed useless to keep the state).

However I hope this helps anyone, who was looking for the same way as I did.

@richjdsmith
Copy link

richjdsmith commented Aug 4, 2023

This is still breaking. Your PR looks to work and ran when tested locally. Not sure how to proceed here. @alexreisner , thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants