Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FontRef::from_face function. #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coevolutions
Copy link

@coevolutions coevolutions commented Oct 25, 2024

This allows FontRefs to be already created from pre-parsed faces. This can be useful to avoid having to reparse a face if we already have one, e.g. if we want to do shaping with rustybuzz, we should already have a parsed face and parsing it a second time is wasteful.

This allows FontRefs to be already created from pre-parsed faces. This can be useful to avoid having to reparse a face if we already have one, e.g. if we want to do shaping with rustybuzz, we should already have a parsed face and parsing it a second time is wasteful.
@alexheretic
Copy link
Owner

This would expose ttf-parser api publicly which is something I deliberately avoid here for semver stability.

@coevolutions
Copy link
Author

I see - I would like to avoid having to reparse the Face though if I already have it. Would you be okay with hiding it behind a feature flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants