Skip to content

factorial function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shellybekhor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

factorial function #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions java/src/factorial.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/**
* Created by Shelly Bekhor on 06-01-20.
Copy link
Owner

@alexger alexger Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what this class does

*/
public class factorial {
static int factorial(int n){
Copy link
Owner

@alexger alexger Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write javadoc

if (n<0){
return -1;
}
else if(n==0){
return 1;
}
else{
return factorial(n-1);
Copy link
Owner

@alexger alexger Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a mistake here. You probably meant n * factorial(n-1)

}
}
}