Partial fix for URLs with localhost:port #148
Open
+60
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #119
localhost:port
URLs are now correctly delimited and no longer cause malformed HTML when passing existing<a>
tags throughanchorme
host
andport
metadata are still missing fromlist
results. This also applies to non-Latin-text URLs such ashttp://www.عربي.com
and is due to theconfirmedByProtocol
regex fragment not capturing those parts. Might be worth fixing at some stage, but for now that metadata is simply missing for those types of URL (which is compatible with the TypeScript definitions). In any case, consumers in environments that support the nativeURL
constructor can just use that to parse the URLs if needed: