-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to Assign Color for Each Commit #220
base: master
Are you sure you want to change the base?
Conversation
@sirrow thanks for the contribution. is there a way to migrate on first startup peoples preferences so that it translates over to the new enum properly? |
@alexcorre I don't make any patches for configuration migration. Also, I have not considered yet how to migrate. |
@sirrow sorry for the delay. i think its ok to skip the migration function. A happy medium would be to first read the new enum config value, if its not present fall back to the old config value. How does that sound? |
@alexcorre
I feel this idea can be implemented a little simpler than migration. |
@alexcorre The reason for retiring implementing the idea is that I want to hide the old config from settings page because it's function is merged new enum config. For reading the old config without showing in setting page, I have to develop another function for reading config for git-blame plugin outside of atom config API. This is too nasty. In my opinion, for for implementing this config migration cleanly some new function like below is necessary.
If someone knows better simple way, please tell me. 😢 |
On v.1.4.0, the new feature assigning colors for each author is great.
Furthermore, I want to assign colors for each commit.