Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Crash when launching from background while audio playing; Ability to manage Sample Rate #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

soulfly
Copy link

@soulfly soulfly commented Mar 5, 2013

My fork contains 2 changes:

  1. Fixed issue Crash when launching from background while audio playing #15 (comment)
  2. Now you can manage these variables:

define sampleRateT 8000.0

define IOBufferDuration 0.0232*2

look at this file https://github.com/soulfly/novocaine/blob/master/Novocaine/Novocaine.m
I think custom sample rate in your origin repo isn't working, i tried to set something other that 44100, but always 44100 i saw in log.
So, please review this issue and add to origin repo if you accept it.

Thanks

@alexbw
Copy link
Owner

alexbw commented May 23, 2013

@ndonald2 Is this redundant with the pull request you merged?

@ndonald2
Copy link
Collaborator

Not redundant - there are some useful changes in here (methods to route to speaker) but also a few things that I don't think should be merged in (voiceprocessing subtype by default - should maybe be an option, but not default)

I don't know enough about the crash fix to verify it or not.

@alexbw
Copy link
Owner

alexbw commented Nov 15, 2013

Is this something that we still should merge in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants