Use upstream frontend nginx.conf and generate ingress config at startup #2415
+17
−180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
nginx.confwith the upstream frontendnginx.confso the add-on follows the source project's nginx layout and defaults.Description
nginx.conffrom the frontend build stage into the image at build time withCOPY --from=frontend-builder /src/frontend/nginx.conf /etc/nginx/servers/nginx.confinDockerfile.rootfs/etc/nginx/servers/nginx.confto usehttp://apiandhttp://icecast(andhttp://api:5002/socket.io/) so the source file matches upstream.rootfs/etc/cont-init.d/32-nginx_ingress.shtosed-rewriteproxy_pass http://apiandproxy_pass http://icecasttoproxy_pass http://127.0.0.1, duplicatenginx.conftoingress.conf, update thelistendirective to the ingress interface/port, and insertinclude /etc/nginx/includes/ingress_params.confinto the generated ingress config.ingress_params.confby replacing%%ingress_entry%%and%%ingress_entry_modified%%at startup.versionto"0.6.2"inconfig.yamland updateCHANGELOG.mdto document the change.Testing
Codex Task