Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image content style of monster detail #325

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Change image content style of monster detail #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b0740
Update Main.yml
alexandregpereira Aug 18, 2024
0596c64
Change image content style of monster detail
alexandregpereira Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/Main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ jobs:
- name: Grant execute permission for gradlew
run: chmod +x gradlew

- name: Verify database migration
run: chmod +x ./scripts/sqldelight/verifyDatabaseMigration && ./scripts/sqldelight/verifyDatabaseMigration

- name: Build with Gradle
env:
MONSTER_COMPENDIUM_KEYSTORE_PASSWORD: ${{ secrets.MONSTER_COMPENDIUM_KEYSTORE_PASSWORD }}
run: ./gradlew jvmTest testReleaseUnitTest assembleRelease bundleRelease :app:packageDmg

- name: Verify database migration
run: chmod +x ./scripts/sqldelight/verifyDatabaseMigration && ./scripts/sqldelight/verifyDatabaseMigration

- name: Upload the test report
if: failure()
uses: actions/[email protected]
Expand Down
4 changes: 2 additions & 2 deletions ui/core/src/commonMain/kotlin/br/alexandregpereira/hunter/ui/compose/MonsterCoilImage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ fun MonsterCoilImage(
shape: Shape = RectangleShape,
modifier: Modifier = Modifier,
backgroundColor: String,
contentScale: ContentScale = ContentScale.Fit,
contentScale: ContentScale = ContentScale.Crop,
graphicsLayerBlock: GraphicsLayerScope.() -> Unit = {},
) = MonsterCoilImage(
imageUrl = imageUrl,
Expand All @@ -53,7 +53,7 @@ fun MonsterCoilImage(
shape: Shape = RectangleShape,
modifier: Modifier = Modifier,
backgroundColor: Color? = null,
contentScale: ContentScale = ContentScale.Fit,
contentScale: ContentScale = ContentScale.Crop,
graphicsLayerBlock: GraphicsLayerScope.() -> Unit = {},
) {
CoilImage(
Expand Down
Loading