Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger nanos support #33

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Ledger nanos support #33

merged 4 commits into from
Oct 16, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented Oct 16, 2024

No description provided.

@Lbqds Lbqds requested a review from polarker October 16, 2024 11:07
Lbqds
Lbqds commented Oct 16, 2024
View reviewed changes
app/src/nvm/nvm_data.rs
@@ -0,0 +1,17 @@
pub struct NVMData<T> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ledger rust sdk does not define a get_ref method for nanos, and I recall the ledger developers mentioning plans to remove support for nanos from the rust sdk. So I added a definition of NVMData for nanos.

@Lbqds
Copy link
Member Author

Lbqds commented Oct 16, 2024

@polarker I created a new develop branch. Perhaps we should set develop as the default branch.

@polarker
Copy link
Member

@polarker I created a new develop branch. Perhaps we should set develop as the default branch.

Let’s keep master as the default branch so Nano S users can easily find it. We’ll use the develop branch for ongoing development work.

@polarker polarker merged commit 513891a into master Oct 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarker polarker Awaiting requested review from polarker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lbqds @polarker