Support for OAuth2 #284
Open
Support for OAuth2 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'userinfo' to valid includes and require authentication for it.
OAuth2 API is described in the MusicBrainz documentation. It offers the ability to fetch a token, revoke it or refresh from the refresh token. Note that the API answers in JSON only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here is a suggestion for the OAuth2 support. There is an intermediate commit to add the API userinfo as this is the example given by
Related to issue #89
It might not exactly sure it does fit to your coding style, but maybe you can help on this ?
I am not sure neither how this can be automatically tested. Here is a script I have made for tests: https://privatebin.net/?c2c1cd266e29aff2#22qmxEqCGs3Wi9fbbLW61NxxKsYeCSsb2zbs3pNo7bn3
Thanks,