Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from urllib to requests #273

Closed
wants to merge 1 commit into from

Conversation

nikosmichas
Copy link

Hello! I had some issues with sockets staying in TIME_WAIT state after failure in the http request and I decided to try requests library instead of urllib.
I revived #199 which revived #123

Is there any interest in merging this?

Rebased from alastair#199

Co-authored-by: Adrian Sampson <[email protected]>
Co-authored-by: Wieland Hoffmann <[email protected]>
@alastair
Copy link
Owner

Yes, let's do it!
When requests first turned up on the scene I was still of the belief that it made sense for libraries to be as stand-alone as possible, and that we have a perfectly functional request handling code in the library.
However, over the years it's become clear that requests is the defacto library for doing this, and it's almost always the first thing that I install when I start something new anyway....
so let's go for it! I'd like to merge in the other open PRs first, using the existing urllib code, and then make a release. After that we can make another release with the switch to requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants