GHC 9.8 support #134
Merged
GHC 9.8 support #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiles, passes most tests. Cases: 3347 Tried: 3347 Errors: 6 Failures: 3
WIP Using the approach from ghc-exactprint master, print the comment form, not the Haddock docs embedded in the AST.
We get synthesised DocD top level decls, and must filter them out when printing, otherwise we process the anchor in the location, messing with comments belonging to the end of the prior decl.
It is always calld with layout as True, so remove the parameter
Needs an update to WarningTxt for WarningCategory. MR coming.
Time to check the roundtrip
Three new cases to investigate. 70k/220k files still to check
Works with ghc-9.8.1 alpha4 It is the only remaining failure, after processing 217k files
https://gitlab.haskell.org/ghc/ghc/-/issues/23984 After parsing, fix up the header comments by looking for a `where` keyword and moving any comments in the first declaration that precede it into the header comments. This only affects a specific scenario where - There are comments in the lines before the module header - There is a comment on the same line as the 'where', preceding it - There is a decl immediately following the line with the comment and 'where' token
And add a test for module header comments without a space.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.