-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): warehouse creation wizard #2728
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Remington Breeze <[email protected]>
> readonly view in promotions modal > create stage with promotion directive steps Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
…romotion-step-wizard
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
…e.less Co-authored-by: Rafal <[email protected]> Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
…branch 'origin' into Marvin9/feat-warehouse-wizard
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
…-warehouse-wizard
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
- Coverage 49.16% 49.16% -0.01%
==========================================
Files 270 270
Lines 19356 19363 +7
==========================================
+ Hits 9516 9519 +3
- Misses 9218 9221 +3
- Partials 622 623 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
I took this for a test drive. I think it's a great start, but it feels a little rough still. Some issues I encountered... This felt awkward because the names For reference: I wonder if we could just not have any heading on each subscription? The next issue was that the form misled me into believing I can create a subscription that use more than one of git, image, or chart. Ex: I knew that these were mutually exclusive, so I tried it and ended up with the expected error: If we could have a drop down where you select to create a git, image or chart subscription, and then have that open one specific sub-form or another, that seems it might prevent the confusion. The last is that I felt like some sort of help text might be in order for most of these fields. I still do think this is a great start, but unless @jessesuen feels strongly about it this being in v1.0.0, I might like to hold this for v1.1.0 so that this can be refined a bit more. |
fixes #1538
Screen.Recording.2024-10-11.at.1.44.37.PM.mov