Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): warehouse creation wizard #2728

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Oct 11, 2024

fixes #1538

Screen.Recording.2024-10-11.at.1.44.37.PM.mov

rbreeze and others added 30 commits September 19, 2024 10:05
> readonly view in promotions modal
> create stage with promotion directive steps

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
…branch 'origin' into Marvin9/feat-warehouse-wizard
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@Marvin9 Marvin9 requested a review from a team as a code owner October 11, 2024 16:46
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 4b45279
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67098e6bc025450008ec47c3
😎 Deploy Preview https://deploy-preview-2728--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (2bb71f2) to head (4b45279).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   49.16%   49.16%   -0.01%     
==========================================
  Files         270      270              
  Lines       19356    19363       +7     
==========================================
+ Hits         9516     9519       +3     
- Misses       9218     9221       +3     
- Partials      622      623       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@krancour
Copy link
Member

I took this for a test drive. I think it's a great start, but it feels a little rough still.

Some issues I encountered...

This felt awkward because the names subscription-1, subscription-2, etc. look like some sort of identifiers, which I cannot control. I know they're just indices, but it felt weird.

For reference:

Screenshot 2024-10-11 at 7 36 02 PM

I wonder if we could just not have any heading on each subscription?

The next issue was that the form misled me into believing I can create a subscription that use more than one of git, image, or chart. Ex:

Screenshot 2024-10-11 at 7 39 44 PM

I knew that these were mutually exclusive, so I tried it and ended up with the expected error:

Screenshot 2024-10-11 at 7 38 25 PM

If we could have a drop down where you select to create a git, image or chart subscription, and then have that open one specific sub-form or another, that seems it might prevent the confusion.

The last is that I felt like some sort of help text might be in order for most of these fields.

I still do think this is a great start, but unless @jessesuen feels strongly about it this being in v1.0.0, I might like to hold this for v1.1.0 so that this can be refined a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warehouse creation wizard
3 participants