Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating freight aliases #2606

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fykaa
Copy link
Contributor

@fykaa fykaa commented Sep 30, 2024

Addressed an inconsistency in the Kargo documentation related to updating aliases for Freight resources.

Before

image

After

image

Signed-off-by: Faeka Ansari <[email protected]>
@fykaa fykaa self-assigned this Sep 30, 2024
@fykaa fykaa requested review from a team as code owners September 30, 2024 08:42
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit fbc1fcc
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66fa73b8b4175800087c814e
😎 Deploy Preview https://deploy-preview-2606.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.41%. Comparing base (b4cf8ca) to head (d1edb50).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
- Coverage   51.09%   49.41%   -1.68%     
==========================================
  Files         282      270      -12     
  Lines       20961    19498    -1463     
==========================================
- Hits        10709     9635    -1074     
+ Misses       9584     9238     -346     
+ Partials      668      625      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fykaa fykaa requested a review from krancour October 7, 2024 05:37
@krancour
Copy link
Member

krancour commented Oct 8, 2024

Nice catch. One comment about formatting and then LGMT.

docs/docs/15-concepts.md Outdated Show resolved Hide resolved
@krancour krancour removed this from the v1.0.0 milestone Oct 11, 2024
Signed-off-by: Faeka Ansari <[email protected]>
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit d1edb50
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/670dee00b9ec2100083c842d
😎 Deploy Preview https://deploy-preview-2606--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fykaa fykaa requested a review from krancour October 15, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants