ak sparse: keep all dirs appart addons #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for odoo (src), we need to keep all the dirs and exclude ./addons/ the previous implementation was doing a `ls`. so it was not working if src was initialized with `git clone --filter:blob=null` because ls was returning nothing. This implementation asks git to list all the dirs expected in . also run a linter on the file
nayatec
reviewed
Feb 5, 2025
| git["ls-tree"]["-d"]["--name-only"]["HEAD"] | ||
| ) | ||
|
|
||
| # ls-files gives us all the files |
There was a problem hiding this comment.
do you mean "ls-tree gives us all the directories" ?
There was a problem hiding this comment.
yep, I changed the command but not the comment
nayatec
reviewed
Feb 5, 2025
| paths += directories | ||
| paths.remove("addons") # remove ./addons/ |
There was a problem hiding this comment.
What i found is :
- when creating a project with no odoo modules listed in spec (as we have with the current copier) this patch is perfectly ok, (using ak clone && ak sparse && ak build) the docky build will succeed
- but with a odoo module list (and an empty odoo/src) we will lack odoo/src/setup.py
Eventually we have to add someting like :
paths.append("setup.py")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for odoo (src), we need to keep all the dirs and exclude ./addons/ the previous implementation was doing a
ls. so it was not working if src was initialized withgit clone --filter:blob=nullbecause ls was returning nothing.This implementation asks git to list all the dirs expected in .
also run a linter on the file