remove systematic fetch_all #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was introduced in a time when we add a big depth in `git clone` and hope to find a common ancestor now with recent git version and partial clones and stuff, it seems counter productive to put this fetch_all: slower, .git takes 7Gb instead of 2 and in some occasions it never finish. If you really need it, you can put it in spec.yaml and it will continue to work. Again this commit, just stop to silently add the fetch_all in all cases.
|
Hum, but this fetch_all is necessary for this kind of stuff right ? It means that when we use a commit instead of a branch or a pull request, then we have to think about manually set this fetch_all, right ? Actually, isn't it necessary as soon as we use a frozen.yaml ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was introduced in a time when we add a big depth in
git cloneand hope to find a common ancestornow with recent git version and partial clones and stuff, it seems counter productive to put this fetch_all: slower, .git takes 7Gb instead of 2 and in some occasions it never finish.
If you really need it, you can put it in spec.yaml and it will continue to work. Again this commit, just stop to silently add the fetch_all in all cases.