Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker to local dev prerequisites #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebastian-alfers
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the documentation documentation related label Dec 30, 2024
Copy link
Contributor

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we had this requirement there at some point so better if @beritou can check this. Btw, I think we require Docker v27.

* https://curl.se/download.html[`curl` command-line tool, window="new"]
* Docker installed and running
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this in the partial that is included from several places. For local development it is only needed for the local console. In author-your-first-service.adoc we want to start with as few prerequisites as possible, and the local console is at the end of that page. Better to add Docker to that section of the page, where it anyway describes installation of akka cli.

We should review other places where it might be relevant to install Docker.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In author-your-first-service.adoc we want to start with as few prerequisites as possible, and the local console is at the end of that page. Better to add Docker to that section of the page, where it anyway describes installation of akka cli.

I agree, and we already mention the Docker requirement in the local console section at the end https://github.com/akka/akka-sdk/blob/main/docs/src/modules/java/pages/author-your-first-service.adoc?plain=1#L202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants