Validate custom HTTP method names #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroper
commented
Jan 8, 2025
| @@ -465,7 +465,7 @@ private[parser] trait CommonRules { this: Parser with StringBuilding => | |||
| token ~> { s => | |||
| HttpMethods.getForKey(s) match { | |||
| case Some(m) => m | |||
| case None => HttpMethod.custom(s) | |||
| case None => HttpMethod(s, isSafe = false, isIdempotent = false, requestEntityAcceptance = RequestEntityAcceptance.Expected, ConstantFun.anyToTrue) | |||
There was a problem hiding this comment.
For custom headers received by the server, there is no need to validate them because they have already been parsed according to the spec, so skip the validation in HttpMethod.custom.
johanandren
approved these changes
Jan 8, 2025
| class HttpMethodSpec extends AnyWordSpec with Matchers { | ||
| "HttpMethod.custom()" should { | ||
| "accept a valid name" in { | ||
| HttpMethod.custom("Yes.Thi$_is_1~'VAL|D`_me+h*d-^ame!#%&") |
There was a problem hiding this comment.
The most reasonable custom method name I ever saw :D
There was a problem hiding this comment.
It's specified in RFC666 - Gaslighting HTTP resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4460