Add services for ubuntu, debian, redhat and systemd #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,4 +23,27 @@ | |||
| fail("${::operatingsystem} not supported") | |||
| } | |||
| } | |||
|
|
|||
| case $::operatingsystemmajrelease { | |||
| 7, 8: { | |||
There was a problem hiding this comment.
Im not sure what version of ubuntu moved to systemd but that should be here too. This shoulld work for rhel/centos7 and debian 7 and 8.
|
Any update on this? I would like to get this merged. I would be happy to help in anyway. |
|
Hi @cwood sorry for the delay in getting back. Broadly looks good, I think the casing around the OS selections need a bit more work to ensure it's using the right scripts for the right OSs. Ubuntu changed to systemd in 15.04 |
|
Hey @ajcrowe I should be able to get to this and help merge it this week if you got time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the work done by the pr #7 and moved it into here and also added systemd scripts and added more tests. Do you know how to run the acceptance tests? It seems ot be missing the version of puppet to run.