Copy segments into your unsubmitted and SkipNotice changes #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing that is really missing is showing a segment again when upvoting. |
…lighting of current selection.
… but this is the most current UI
|
Implements #370 |
ajayyy
requested changes
Oct 14, 2021
Co-authored-by: Ajay Ramachandran <[email protected]>
…lock into pr/FlorianZahn/988
ajayyy
reviewed
Oct 14, 2021
ajayyy
reviewed
Oct 14, 2021
|
After pressing vote the animation doesnt start showing, that the vote is currently being sent |
ajayyy
approved these changes
Oct 15, 2021
|
Only that it doesnt look up locked segments anymore, menitioned in the review thing above your last comment. |
|
See the latest commit on the server repo, it now will come from the server |
|
Does it already do that? The info is not displayed for me. |
|
The main server is not updated, I was doing my testing with my local server. Will update it tomorrow |
|
In that case everything is fine. Thank you |
|
I forgot to add the isVip check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
Adds a copy button to the SkipNotice, which copies the skipped segment and creates an unsubmitted one with the same category and timings. SkipNoticeUI states have been made more responsive. The SubmissionNotice opener button is now a toggle.