Respect iOS/macOS accent color by using a monochrome toolbar icon for… #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Safari
To test this pull request, follow the instructions in the wiki.
This change would resolve #1324. To recap, Safari on macOS has a feature where active extensions are given the system's chosen accent colour, and inactive extensions are given a translucent appearance. Many (but not all) extensions support this, creating a consistent aesthetic.
For some reason this actually started working on earlier versions of macOS, my screenshot on the issue (#1324 (comment)) shows this, but as of Sequoia, the old behaviour returned and the extension is now red when active. The real fix for this is as mentioned in Jeff Johnson's blog is to use a monochrome (usually just all black) transparent icon for the toolbar, this behaviour is seemingly completely undocumented by Apple. iOS also supports this behaviour, but since you cannot change the accent colour, it is always blue when active.
I figured since Safari already has some manifest overrides, the easiest way would be to override the toolbar icon using that. Below is how it looks during tested on macOS and iOS: