Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GutterTooltip and GutterKeyboardEvent declarations #5715

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: Fix GutterTooltip and GutterKeyboardEvent declarations #5715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ace-internal.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export namespace Ace {
type DragdropHandler = import("./src/mouse/dragdrop_handler").DragdropHandler;
type AppConfig = import("./src/lib/app_config").AppConfig;
type Config = typeof import("./src/config");
type GutterTooltip = typeof import( "./src/mouse/default_gutter_handler").GutterTooltip;
type GutterKeyboardEvent = typeof import( "./src/keyboard/gutter_handler").GutterKeyboardEvent;
type GutterTooltip = import( "./src/mouse/default_gutter_handler").GutterTooltip;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth leaving a comment here on why this is important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that line 29 is the one using typeof. Not using it is the default/straightforward case. If a comment is needed, it should be rather for why it is needed on that line —but I don't have the context to tell (maybe it isn't :))

type GutterKeyboardEvent = import( "./src/keyboard/gutter_handler").GutterKeyboardEvent;

type AfterLoadCallback = (err: Error | null, module: unknown) => void;
type LoaderFunction = (moduleName: string, afterLoad: AfterLoadCallback) => void;
Expand Down
4 changes: 2 additions & 2 deletions ace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ declare module "ace-code" {
type DragdropHandler = import("ace-code/src/mouse/dragdrop_handler").DragdropHandler;
type AppConfig = import("ace-code/src/lib/app_config").AppConfig;
type Config = typeof import("ace-code/src/config");
type GutterTooltip = typeof import("ace-code/src/mouse/default_gutter_handler").GutterTooltip;
type GutterKeyboardEvent = typeof import("ace-code/src/keyboard/gutter_handler").GutterKeyboardEvent;
type GutterTooltip = import("ace-code/src/mouse/default_gutter_handler").GutterTooltip;
type GutterKeyboardEvent = import("ace-code/src/keyboard/gutter_handler").GutterKeyboardEvent;
type AfterLoadCallback = (err: Error | null, module: unknown) => void;
type LoaderFunction = (moduleName: string, afterLoad: AfterLoadCallback) => void;
export interface ConfigOptions {
Expand Down
Loading