Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added is_alm_query() & wp_alm_query() functions #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alifallahrn
Copy link

Hi there,

When I used your plugin in one of my projects, I had to make sure the $post global variable was in the alm_query loop.

Due to the lack of a global function or variable in the plugin code, I was unable to find a simple solution, so I fixed it by using "loop_start" and "loop_end" hooks

When the issue was fixed, I thought it might be a problem for other developers as well, so I added functions to the plugin that would fix it.

I hope it is useful

@dcooney dcooney requested review from dcooney and removed request for dcooney February 2, 2023 19:32
@alifallahrn
Copy link
Author

@dcooney Was it helpful? Is it possible that this pull request will be merged in the future?

@dcooney
Copy link
Collaborator

dcooney commented Feb 14, 2023

@alifallahrn Can you explain how this is useful? Code looks fine but I want to understand the use case for adding these as globals.

@dcooney
Copy link
Collaborator

dcooney commented Jul 27, 2023

@alifallahrn I'd like to get this merged in for you, but can you update the PR with the conflicting files against the new main branch? I also like to know how you are using this and what the use case is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants