-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
連想配列の追加 #693
Closed
Closed
連想配列の追加 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FineArchs
requested review from
syuilo,
marihachi,
salano-ym,
ikasoba,
uzmoi and
kakkokari-gtyih
June 21, 2024 11:48
salano-ym
approved these changes
Jul 5, 2024
FineArchs
requested review from
syuilo,
marihachi,
ikasoba,
uzmoi and
kakkokari-gtyih
and removed request for
syuilo,
marihachi,
ikasoba,
uzmoi and
kakkokari-gtyih
July 10, 2024 09:41
marihachi
reviewed
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
キーを[]
で囲むというのは方針として決まってるものですか?
先にissueの方で提案お願いします
#225内のikasobaさんの案を部分的に採用したものになります。(文字列のキーのより簡潔な表記法については一旦後回しにしています) 方針として確定している訳ではないので、問題提起があれば再検討したいと思います。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
名前空間記法との兼ね合いから、キーは全て
[
]
で囲うようになっています。キーの等価性はdeep-equalになっています(関数のみ参照比較)。
実装
トライ木の構造を採用しています。
その都合上、キーを直列化する仕組みを導入しています。
Why
#225
備考