This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Better gulps #20
Open
vidbina
wants to merge
25
commits into
airtoxin:master
Choose a base branch
from
vidbina:better-gulps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Better gulps #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specs now use `appium-chromedriver` to spawn ChromeDriver and stop it after the testcases. This way one no longer needs to start Chromedriver manually and stop it after the tests have been executed :wink:.
Bundling the transpiled source actually means that we probably could remove everything in the `compile/src/component` directory as it will be bundled into `compile/src/app.js`
Just realised that all tests for an electron app need to be executed by the same node env that runs electron. Rookie mistake and here is an attempt to rectify it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed testing to use
electron-mocha
instead ofmocha
. Made the mistake of forgetting that there may be a discrepancy between the(
io|
Node)
.js versions of Electron.js and the dev env. With my commits I addresses that misunderstanding.