This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Refactored + Setup testing #18
Open
vidbina
wants to merge
16
commits into
airtoxin:master
Choose a base branch
from
vidbina:setup-testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specs now use `appium-chromedriver` to spawn ChromeDriver and stop it after the testcases. This way one no longer needs to start Chromedriver manually and stop it after the tests have been executed :wink:.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored entire project based on .jscsrc as covered in the README. Not very sure if you want this in the project, but I figured it would help to have all the code in the project in the same style. Then again, a style is a matter of preference. The Airbnb style is a very thorough and well documented style.
To top things off I moved all the source into
/src
created a folder for tests calledtest
(maybe this should bespec
) and used ChromeDriver, WebdriverIO and Mocha for a simple test case.