Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve space within single-line code blocks #15

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Preserve space within single-line code blocks #15

merged 1 commit into from
Jan 11, 2024

Conversation

findepi
Copy link
Contributor

@findepi findepi commented Jan 10, 2024

No description provided.

@findepi findepi mentioned this pull request Jan 10, 2024
Closed
@martint martint merged commit 3fbde21 into airlift:master Jan 11, 2024
@findepi findepi deleted the findepi/preserve-space-within-single-line-code-blocks-9ca94b branch January 11, 2024 13:54
@findepi
Copy link
Contributor Author

findepi commented Jan 11, 2024

i just realized the change may have a small side-effect, perhaps anticipated by some

private MyClass() {}

may now format as

private MyClass() { }

@martint
Copy link
Member

martint commented Jan 11, 2024

That’s an acceptable tradeoff, IMO.

@findepi
Copy link
Contributor Author

findepi commented Jan 11, 2024

it reads perfectly, agreed.
not sure whether this violates airbase checkstyle rules though.

@findepi findepi mentioned this pull request Jan 11, 2024
Open
@findepi
Copy link
Contributor Author

findepi commented Jan 11, 2024

Follow-up: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @martint