Skip to content

Conversation

@tolik0
Copy link
Contributor

@tolik0 tolik0 commented Jan 30, 2026

What

Resolves: https://github.com/airbytehq/oncall/issues/11078.

Adds a new slice_step_duration configuration option that allows users to control the time window size for incremental sync slices. The default is changed from one year (P1Y) to one month (P1M), with options for 1 day, 1 week, 1 month, or 1 year.

How

  • Added new slice_step_duration config option in the spec with enum values: P1D (1 Day), P1W (1 Week), P1M (1 Month), P1Y (1 Year)
  • Updated the step parameter in two incremental sync cursor definitions to use {{ config.get('slice_step_duration', 'P1M') }}
  • Updated unit test to use a closer date range that works with the new default monthly slicing

Review guide

  1. airbyte-integrations/connectors/source-twilio/manifest.yaml - New config option and dynamic step parameter
  2. airbyte-integrations/connectors/source-twilio/metadata.yaml - Version bump to 0.17.5
  3. airbyte-integrations/connectors/source-twilio/unit_tests/test_streams.py - Test date range adjustment
  4. docs/integrations/sources/twilio.md - Changelog entry

Human Review Checklist

  • Verify the Jinja interpolation {{ config.get('slice_step_duration', 'P1M') }} works correctly in declarative manifests
  • Confirm all enum values (P1D, P1W, P1M, P1Y) are valid ISO 8601 durations supported by the CDK
  • Verify the test still validates the intended incremental sync behavior with the updated date range

User Impact

Users can now configure the slice step duration for incremental syncs via the new "Slice Step Duration" option. Smaller windows (like 1 day or 1 week) may help avoid timeouts for accounts with large data volumes, while larger windows reduce the number of API requests. The default of 1 month provides a good balance for most use cases.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
  • ❇️ AI Testing and Review:
    • /ai-docs-review - Provides AI-powered documentation recommendations for PRs with connector changes.
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
    • /bump-progressive-rollout-version - Bumps connector version with an RC suffix (2.16.10-rc.1) for progressive rollouts (enableProgressiveRollout: true).
      • Example: /bump-progressive-rollout-version changelog="Add new feature for progressive rollout"
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version bump=patch changelog='foo' - Bump the Bulk CDK's version. bump can be major/minor/patch.
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

source-twilio Connector Test Results

21 tests   18 ✅  27s ⏱️
 2 suites   3 💤
 2 files     0 ❌

Results for commit a6bbe83.

♻️ This comment has been updated with latest results.

@tolik0 tolik0 marked this pull request as ready for review January 30, 2026 20:16
@tolik0
Copy link
Contributor Author

tolik0 commented Jan 30, 2026

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-twilio.
PR: #72494

Pre-release versions will be tagged as {version}-preview.245d04c
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS

Docker image (pre-release):
airbyte/source-twilio:0.17.5-preview.245d04c

Docker Hub: https://hub.docker.com/layers/airbyte/source-twilio/0.17.5-preview.245d04c

Registry JSON:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-at21two1u-airbyte-growth.vercel.app

Built with commit a6bbe83.
This pull request is being automatically deployed with vercel-action

@devin-ai-integration devin-ai-integration bot changed the title fix(source-twilio): Change the default slice duration from one year to one month feat(source-twilio): Add configurable slice step duration (default: 1 month) Feb 2, 2026
@tolik0
Copy link
Contributor Author

tolik0 commented Feb 2, 2026

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-twilio.
PR: #72494

Pre-release versions will be tagged as {version}-preview.a6bbe83
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS

Docker image (pre-release):
airbyte/source-twilio:0.17.5-preview.a6bbe83

Docker Hub: https://hub.docker.com/layers/airbyte/source-twilio/0.17.5-preview.a6bbe83

Registry JSON:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants