fix: docs for default port in typesense connector #49984
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes the doc for the default connector port for the typesense connector.
It is by default 8108 in the connector code, but it was 443 in the docs.
How
Change the doc to say the default port is 8108
Review guide
airbyte/airbyte-integrations/connectors/destination-typesense/destination_typesense/spec.json
Line 27 in d02c1ea
airbyte/airbyte-integrations/connectors/destination-typesense/destination_typesense/destination.py
Line 22 in d02c1ea
User Impact
Users can connect to typesense using airbyte when their typesense instance is secured with ssl, and only port 443 is open.
This should improve this connector's reliability stats amongst ssl users.
Can this PR be safely reverted and rolled back?