Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs for default port in typesense connector #49984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soumilbaldota
Copy link

What

This fixes the doc for the default connector port for the typesense connector.
It is by default 8108 in the connector code, but it was 443 in the docs.

How

Change the doc to say the default port is 8108

Review guide

  1. "description": "Port of the Typesense instance. Ex: 8108, 80, 443. Default is 443",
  2. node = {"host": host, "port": config.get("port") or "8108", "protocol": config.get("protocol") or "https"}

User Impact

Users can connect to typesense using airbyte when their typesense instance is secured with ssl, and only port 443 is open.
This should improve this connector's reliability stats amongst ssl users.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 21, 2024

@soumilbaldota is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants