feat(source-sendgrid): Upgrade to latest manifest-only CDK version to enable concurrency for all streams #49812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
brianjlai
changed the title
|
regression test notes:
acceptance test notes:
Despite the mismatches, I believe this upgrade is working as expected |
brianjlai
commented
Dec 31, 2024
| @@ -640,6 +640,8 @@ definitions: | |||
| path: "{{stream_slice['url']}}" | |||
| url_base: "" | |||
| http_method: GET | |||
| download_extractor: | |||
| type: ResponseToFileExtractor | |||
There was a problem hiding this comment.
There was a subtle change in this PR: https://github.com/airbytehq/airbyte-python-cdk/pull/50/files#diff-1d9bc4ca384e5c00867da05e9db9d919aba908c59bb73aab83883b9ed20def05L2040
Where we no longer automatically used the ResponseToFileExtractor if download_extractor was not defined. Instead we defaulted to the JsonDecoder which broke sendgrid. Since this was the only use of AsyncRetriever, its easy enough to just fix it here instead of a full breaking change.
|
/approve-regression-tests validated mismatches and mentioned in above notes
|
artem1205
approved these changes
Dec 31, 2024
…_retriever_refactor
brianjlai
changed the title
|
closed in favor of #48238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sendgrid is currently our only certified connector that uses the new(ish)
AsyncRetriever. In order to test the component migration to make async job streams concurrent, we want to release it to this connector.The
contactsstream is the only async stream. But we've made some improvements forSimpleRetrieverto be stateless which should not impact things under the hood.User Impact
n/a
Can this PR be safely reverted and rolled back?