feat(source-linkedin-ads): move custom streams to manifest only #48863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
…treams-to-manifest-only
…treams-to-manifest-only
…treams-to-manifest-only
…ifest-only' of github.com:airbytehq/airbyte into lazebnyi/source-linkedin-ads-move-custom-streams-to-manifest-only
maxi297
reviewed
Dec 18, 2024
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linkedin-ads/unit_tests/test_source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-linkedin-ads/unit_tests/test_source.py
Outdated
Show resolved
Hide resolved
…treams-to-manifest-only
|
/format-fix
|
maxi297
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With new version of CDK streams can be created dynamically via config deduction. So we can move from custom implementation to cdk based.
Fixed: https://github.com/airbytehq/airbyte-internal-issues/issues/10790
How
Deleted all custom method from source and add dynamic streams definition to the manifest. Stream name moved to a higher level, as the record selector now also requires the stream name for instance creation, like the retriever.
Review guide
manifest.yamlsource.pyNOTE: COULD BE REVIEW/TESTED WITH CI AFTER THIS - airbytehq/airbyte-python-cdk#149
User Impact
No
Can this PR be safely reverted and rolled back?