Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (DeclarativeOAuthFlow) - make the extract_output Optional; correct the descriptions #106

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

bazarnov
Copy link
Contributor

@bazarnov bazarnov commented Jan 21, 2025

What

Resolving:

After this change: https://github.com/airbytehq/airbyte-platform-internal/pull/15040, there is no need to have the extract_output as the required field to be provided, we will leverage the complete_oauth_output_specification.path_in_oauth_response instead.

User Impact

No impact is expected. This is not a breaking change.

@bazarnov
Copy link
Contributor Author

@bnchrch This CI check is red, for an unknown reason to me: https://github.com/airbytehq/airbyte-protocol/actions/runs/12892021428/job/35945312729?pr=106

I've also tested on a clean main branch, here is the TEST ON MAIN PR, it fails the same way, which is worth tackling, I believe.

Who is responsible for maintaining this repo and the related processes?

@bazarnov
Copy link
Contributor Author

bazarnov commented Jan 21, 2025

Running the protocol-models/bin/generate-python-pydantic-v2-docker.sh locally fails with the same way for the main branch.

@bnchrch
Copy link
Contributor

bnchrch commented Jan 22, 2025

@bazarnov I believe I have a fix here. Will merge once tests pass.

@bazarnov
Copy link
Contributor Author

@bazarnov I believe I have a fix here. Will merge once tests pass.

If you can provide the details, it'd be helpful for future reference. Thanks.

@bnchrch
Copy link
Contributor

bnchrch commented Jan 22, 2025

@bazarnov merged here #108

@bazarnov bazarnov merged commit 94b0198 into main Jan 23, 2025
6 checks passed
@bazarnov bazarnov deleted the baz/doaf-make-extract-output-optional branch January 23, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants