[Feature Request] Compose - CollectAsStateWithLifecycle #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihart
reviewed
Apr 3, 2024
.idea/codeStyles/Project.xml
Outdated
| @@ -1,11 +1,6 @@ | |||
| <component name="ProjectCodeStyleConfiguration"> | |||
| <code_scheme name="Project" version="173"> | |||
| <JetCodeStyleSettings> | |||
| <option name="PACKAGES_TO_USE_STAR_IMPORTS"> | |||
Add Compose-related convenience functions to collect a State variable in a lifecycle-aware manner. Mirror `collectAsState` extension functions and create the lifecycle-aware version `collectAsStateWithLifecycle`. Add new dependency to `androidx.lifecycle:lifecycle-runtime-compose`. Update `ComposeSampleActivity` to use one of the new `collectAsStateWithLifecycle` extension function.
JuxBzh
force-pushed
the
f/collectAsStateWithLifecycle
branch
from
5f035f5
to
008cf3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested by this article from Manuel Vivo, a flow can be consumed in a lifecycle-aware manner to avoid wasting app resources.
Following this advice, I updated
MavericksComposeExtensionfile to expose lifecycle-aware version ofcollectAsStatefunctions.Changes
lifecycle-runtime-composeto be able to useFlow.collectAsStateWithLifecyclefunctioncollectAsStateWithLifecyclefunctions mirroring the existingcollectAsStatefunctionssample-composeto usecollectAsStateWithLifecycleandcollectAsStatefunctions