UPDATE: Readme file update with specificity,Responsiveness and common pitfalls #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandhya-Madhuri
changed the title
anandfresh
approved these changes
Oct 14, 2024
ljharb
requested changes
Oct 14, 2024
| button: { | ||
| color: "red", | ||
| }, | ||
| specialButton: { |
There was a problem hiding this comment.
why is this an improvement? .specialButton targets a class, and specialButton targets a nonexistent tag name. did you mean 'button.specialButton'?
There was a problem hiding this comment.
specialButton in the second is just a property to styles. It is not a class we pass it using styles.specialButton. It is a css-in-js syntax
There was a problem hiding this comment.
can you elaborate? I’m not familiar with any css-in-js solution that conflates tag names and class names in this way.
| button: { | ||
| color: "red", | ||
| }, | ||
| specialButton: { |
There was a problem hiding this comment.
Suggested change
| specialButton: { | |
| 'button.specialButton': { |
Comment on lines
+582
to
+585
| buttonActive: { | ||
| color: "green", | ||
| }, | ||
| buttonInactive: { |
There was a problem hiding this comment.
again, should these be class names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.