Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graceful service shutdown #53

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

tzoiker
Copy link
Contributor

@tzoiker tzoiker commented Oct 28, 2019

Sometimes it is desirable to create tasks within a service that will either be awaited or cancelled upon service exit. Added

  • GracefulMixin - creates and stores tasks for cancellation or waiting;
  • GracefulService - performs graceful shutdown on stop.

@mosquito
Copy link
Collaborator

mosquito commented Feb 5, 2020

Please fix tests and rebase.

Artyom Nikitin added 5 commits November 7, 2020 00:35
@tzoiker
Copy link
Contributor Author

tzoiker commented Nov 11, 2020

@mosquito is it better for create_graceful_task to have cancel=True by default? Decided to make it cancel=False.

Artyom Nikitin added 2 commits November 25, 2020 00:20
# Conflicts:
#	docs/source/locale/ru/LC_MESSAGES/services.po
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants