-
-
Notifications
You must be signed in to change notification settings - Fork 175
Add the URL subtraction feature #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b376aa6 to
fd5e4ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (97.98%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 99.57% 99.58%
=======================================
Files 29 29
Lines 5881 5978 +97
Branches 266 271 +5
=======================================
+ Hits 5856 5953 +97
Misses 21 21
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1538 will not alter performanceComparing Summary
Benchmarks breakdown
|
|
+1 for making it look trivial |
fd5e4ee to
115cb86
Compare
115cb86 to
df318fa
Compare
|
I added this one to my review queue. Sadly its a ~400 PRs deep right now. I'm hoping to dig myself out of the hole during the holiday at the end of the month |
|
Oof, 400 PRs… Anyway, thanks for the update! Hope you get some breathing room soon 🥲 |
What do these changes do?
Rework of the URL subtraction feature (added in #1340; removed in #1391)
Are there changes in behavior for the user?
Being able to calculate the relative path between two URLs:
As suggested in #1392 (review), the idea is (temporarily?) implemented as a regular method, not a subtraction operator.
Related issue number
Resolves #1183
Checklist
Known issues